src: miscellaneous cleanups for node_config
Includes a fix for setting the icuDataDir
as a UTF8 string rather than one byte. Previously, if the dir contained any non-ascii characters they would be mangled. This won't cover cases that involve paths with other character encodings (thank you Linux).. but it will cover the most likely. (ping @srl295).
It is not currently possible to add a test for this case as we do not have a full-icu data dir we can test against in the CI suite.
Other miscellaneous cleanups are included
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
commit message follows commit guidelines
Affected core subsystem(s)
src