Skip to content

http2: refactor error handling

Rodrigo Muino Tomonari requested to merge github/fork/mcollina/http2-errors into master

This changes the error handling model of ServerHttp2Stream, ServerHttp2Request and ServerHttp2Response. An 'error' emitted on ServerHttp2Stream will not go to 'uncaughtException' anymore, but to the server 'clientError'. On the stream 'error', ServerHttp2Request will emit 'abort', while ServerHttp2Response would do nothing

See: https://github.com/nodejs/node/issues/14963

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

Merge request reports