Skip to content

net: cleanup connect logic and add ability to specify custom lookup function

Rodrigo Muino Tomonari requested to merge github/fork/evanlucas/cleanup-connect into master

Separates out the lookup logic for net.Socket. In the event the host property is an IP address, the lookup is skipped.

Also allows customization of the lookup function in Socket.prototype.connect.

Ref: https://github.com/joyent/node/issues/8475

I used lookup instead of resolve since we are actually calling lookup currently. I wasn't sure if we wanted to go ahead and change to using resolve or not. If we did, what kind of impact would that have?

Merge request reports