Skip to content

http2: adjust error types, increase test coverage

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/patch-test-http2-connect-method-errors into master

A few small things:

  • changed error types emitted from request and validatePriorityOptions (when validating options provided) to be TypeError rather than RangeError
  • added tests to confirm that errors for all options are thrown as expected (weight, parent, exclusive, silent, endStream and getTrailers)
  • added test for method CONNECT (in client request) throwing errors on missing :authority or superfluous :scheme and :path

Please let me know if there's anything I can adjust. Thanks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

Merge request reports