Skip to content

test: remove faulty test case

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/remove-faulty-test into master

While working on #14881 the test added in da1af3d3 started to fail for me. So I digged into that and realized that the output is not coming from the console.log in the catch part but from "somewhere". When applying the following patch it will print something different then expected.

diff --git a/test/message/stack_overflow_async.js b/test/message/stack_overflow_async.js
index 9aefbf9557..f83104ed44 100644
--- a/test/message/stack_overflow_async.js
+++ b/test/message/stack_overflow_async.js
@@ -11,7 +11,7 @@ async function g() {
   try {
     await f();
   } catch (e) {
-    console.log(e);
+    console.log('e');
   }
 }
(node:4559) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): RangeError: Maximum call stack size exceeded
(node:4559) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

When adding a console.log() or process.stdout.write("") before the test it will not print "e" either but

RangeError: Maximum call stack size exceeded
    at f (/home/ruben/repos/node/node/t.js:23:1)
    at f (/home/ruben/repos/node/node/t.js:22:9)
    at f (/home/ruben/repos/node/node/t.js:22:9)

So the test is not working as anticipated and I removed it so #14881 can land.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports