Skip to content

Http2 test coverage for ServerHttp2Stream.respondWithFD

Rodrigo Muino Tomonari requested to merge github/fork/ssbrewster/http2-test-respondfd into master

This PR increases test coverage in ServerHttp2Stream.respondWithFD and corrects HTTP_STATUS_CONTENT_RESET to HTTP_STATUS_RESET_CONTENT in lib/internal/http2/core.js.

Once I've got feedback on this PR I can do something similar for ServerHttp2Stream.respondWithFile (that I think should push the branch coverage for core.js into the green).

Refs: https://github.com/nodejs/node/issues/14985

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

Merge request reports