Skip to content

deps: update V8 to 6.2

Rodrigo Muino Tomonari requested to merge github/fork/targos/v8-6.2 into master

I'm opening this early to track the issues that need fixing.

Blocking issues

Compilation failure with Clang (macOS, FreeBSD)

Error 
In file included from ../deps/v8/src/compiler/common-operator.cc:5:
In file included from ../deps/v8/src/compiler/common-operator.h:8:
In file included from ../deps/v8/src/assembler.h:38:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/forward_list:173:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/memory:602:
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/utility:318:37: error: no type named 'type' in 'std::__1::enable_if<false, void>'; 'enable_if' cannot be used to disable this declaration
                 typename enable_if<is_convertible<_U1, _T1>::value &&
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/compiler/common-operator.h:137:62: note: in instantiation of member function 'std::__1::pair<unsigned int, const v8::internal::ZoneVector<v8::internal::MachineType> *>::pair' requested here
  using std::pair<uint32_t, const ZoneVector<MachineType>*>::pair;
                                                             ^
../deps/v8/src/base/functional.h:143:69: note: while substituting deduced template arguments into function template 'TypedObjectStateInfo' [with _U1 = unsigned int, _U2 = int]
  V8_INLINE size_t operator()(T const& v) const { return hash_value(v); }
                                                                    ^
../deps/v8/src/compiler/operator.h:188:47: note: in instantiation of member function 'v8::base::hash<v8::internal::compiler::ObjectStateInfo>::operator()' requested here
    return base::hash_combine(this->opcode(), this->hash_(this->parameter()));
                                              ^
../deps/v8/src/compiler/operator.h:169:3: note: in instantiation of member function 'v8::internal::compiler::Operator1<v8::internal::compiler::ObjectStateInfo, v8::internal::compiler::OpEqualTo<v8::internal::compiler::ObjectStateInfo>, v8::internal::compiler::OpHash<v8::internal::compiler::ObjectStateInfo> >::HashCode' requested here
  Operator1(Opcode opcode, Properties properties, const char* mnemonic,
  ^
../deps/v8/src/compiler/common-operator.cc:1260:23: note: in instantiation of member function 'v8::internal::compiler::Operator1<v8::internal::compiler::ObjectStateInfo, v8::internal::compiler::OpEqualTo<v8::internal::compiler::ObjectStateInfo>, v8::internal::compiler::OpHash<v8::internal::compiler::ObjectStateInfo> >::Operator1' requested here
  return new (zone()) Operator1<ObjectStateInfo>(  // --
                      ^

Windows test failure

This one is because we do not support building addons with VS2013 anymore. We need to stop testing this on Node >=9.0.0.

Merge request reports