Skip to content

assert: use Same-value equality in deepStrictEqual

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/assert-minus-zero into master

This is one of the last changes I think is necessary to make assert.deepStrictEqual really great.

As a side-effect I also improved the performance for Float*Array immensely. It depends on the size of the TypedArray but especially unequal ones will be found much, much faster now.

I also aligned Float*Array with other TypedArrays in assert.deepEqual. This was not the case and it was tested stricter before (as in testing for extra properties).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

Merge request reports