Skip to content

async_hooks: skip sanity checks when disabled

Rodrigo Muino Tomonari requested to merge github/fork/AndreasMadsen/async-hooks-opt-in-checks into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

While async_hooks is experimental we should skip the sanity checks when async_hooks is disabled. If someone would like a flag as well, we could add another async_hooks_field that is > 0 when either the flag is used or the hooks are enabled. Should be trivial.

This makes the sanity checks stricter when async_hooks is enabled, so be sure to run CITGM before merging this. However, since async_hooks is rarely enabled there shouldn't be any issues.

CI: https://ci.nodejs.org/job/node-test-pull-request/10120/

Ref: https://github.com/nodejs/node/pull/14387 Ref: https://github.com/nodejs/node/pull/14722 Ref: https://github.com/nodejs/node/issues/14717 Ref: https://github.com/nodejs/node/issues/15448

Merge request reports