Skip to content

doc: fix mistake in http2stream.respondWithFile.

Rodrigo Muino Tomonari requested to merge github/fork/antoine-amara/doc-#15390-update-responseWithFile into master

http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake.

Add a description more informations when onError is triggered.

Fixes: https://github.com/nodejs/node/issues/15390

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports