Skip to content

test: fix assert.throws in test-http-invalid-urls

Rodrigo Muino Tomonari requested to merge github/fork/Trott/assert-throws-booboo into master

When the second argument to assert.throws() is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in test-http-invalid-urls.js.

Instead of skipping the test when there is no crypto, the test is now run but with http only. https is skipped.

Logging was fixed. Previously, errors would be written out as being in the [object Object] module rather than http or https.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports