Skip to content

meta: provide a two-week review period for semver-major

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/semver-major-review-time-limit into master

Allow semver-major pull requests to land after two weeks of review if there are no explicitly objections, even if there are not two TSC members signing off.

The reasons are fairly straightforward: the internal/errors conversion has taken a lot longer than it really needed to take because of delays in getting TSC members to actually review the PRs. This PR allows semver-major's to land after two weeks of review if there is signoff from collaborators, even if there are not two TSC members signing off.

If there are objections, it goes to a vote, as things currently happen.

ping @mcollina

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports