Skip to content

[v6.x backport] repl: refactor `LineParser` implementation

Rodrigo Muino Tomonari requested to merge github/fork/lance/15704-unterminated-template-literal into v6.x-staging

Backporting this PR to address https://github.com/nodejs/node/issues/15704. In addition to the basic backport, I have added a test test/parallel/test-repl-multi-line-templates.js to test for the issue noted in the issue above.

Original pull request: https://github.com/nodejs/node/pull/6171

Original commit message:

Move the core logic from LineParser should fail handling into the recoverable error check for the REPL default eval.

PR-URL: https://github.com/nodejs/node/pull/6171 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

Merge request reports