Skip to content

n-api: make changes for source compatibility

Rodrigo Muino Tomonari requested to merge github/fork/gabrielschulhof/napi-rename-new-target into master

These changes are necessary in order to retain source compatibility with older versions of node.

The removal of module_version from napi_module_register() is reverted from the flag removal PR, because it should not have been a part of it.

CallbackWrapper::NewTarget() is renamed to CallbackWrapper::GetNewTarget() to distinguish it from V8's native method, thus allowing for a macro which reduces NewTarget() to This() on V8 versions where it was not yet available.

AsyncResource is constructed with a C string rather than a V8 string because the former is available on all versions of node.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

Merge request reports