Skip to content

doc: exempt test/doc only changes from 48-hr rule

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/48-hours-exempt-docs-tests into master

If a change affects only specific parts of the tests and or documentation, and in particular not of the runtime code itself, it should often be okay to land it early.

The primary goal of the 48-hour rule is to ensure that people who are invested in certain parts of Node have a reasonable chance to weigh in based on their usage of Node; if the API is not touched in a change, that is arguably much less of an issue.

In particular, this:

  • Should help avoid excessive nitpicking.
  • Helps newcomers, since their first PRs often touch only those areas and a direct success is very motivating.
  • Helps with the amount of pull requests created by events such a Code & Learn.
Checklist
Affected core subsystem(s)

@nodejs/tsc

I can’t be there but if you feel it’s worth pointing to this PR in today’s TSC meeting please do so :)

Merge request reports