tools: update to ESLint 4.8.0
The first commit addresses an extraneous space in lib/modules.js
which seems to go unnoticed in v4.3.0 of eslint
but gets flagged by v4.8.0. The second commit upgrades to eslint@4.8.0
. This mimics the PRs for 4.2.0 & 4.3.0 upgrades.
Here's the changelog: https://github.com/eslint/eslint/blob/master/CHANGELOG.md (Quite a few bug fixes & also some perf changes so I figured it was worth upgrading)
/cc @trott (since you did the 4.2.0 & 4.3.0 updates)
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
commit message follows commit guidelines
Affected core subsystem(s)
lib, tools