Skip to content

domain: re-implement domain over async_hook

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Tentative to re-implement domains over async_hook API.

Currently this breaks the following tests:

  • those using --abort-on-uncaught-exception flag: I have not found a way to intercept those errors event by looking to process._fatalException
    • parallel/test-domain-abort-on-uncaught.js
    • parallel/test-domain-with-abort-on-uncaught-exception
  • the one which expect an exit code of 7 when an error is thrown from a domain error handler: I have not found where this was done in the previous version.
    • test-domain-top-level-error-handler-throw
  • those linked to makeCallback: It seems there is some domain handling happening in native code I could not fix.
    • addons/make-callback-recurse/test
    • addons-napi/test_make_callback_recurse/test

Merge request reports

Loading