Skip to content

tty: fix 'resize' event regression

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/fix16194 into master

It's not wholly clear what commit introduced the regression but between v8.4.0 and v8.5.0 the 'resize' event stopped getting emitted when the tty was resized.

The SIGWINCH event listener apparently was being installed before the support code for process.on('SIGWINCH', ...) was. Fix that by moving said support code to real early in the bootstrap process.

Fixes: https://github.com/nodejs/node/issues/16194 CI: https://ci.nodejs.org/job/node-test-pull-request/10732/

Merge request reports

Loading