Skip to content

deps: cherry-pick 37a3a15c3 from V8 upstream

This is a backport of a fix for some V8 interceptor functions. I'd like to back port this so we can fix the vm module in Node 9. What do you think? Or should we wait until V8 64 lands regularly?

Original commit message: [api] Intercept DefineProperty after Descriptor query

Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor.

This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example https://github.com/nodejs/node/pull/13265

Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas ahaas@chromium.org Commit-Queue: Franziska Hinkelmann franzih@chromium.org Cr-Commit-Position: refs/heads/master@{#48683}

Checklist
Affected core subsystem(s)

deps

Merge request reports

Loading