Skip to content

http2: do not allow socket manipulation

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/patch-http2-core-socket into master

This addresses https://github.com/nodejs/node/issues/16252. I still need to update the documentation and potentially the error message but figured the review could get started.

We might need to discuss how much stuff we forbid on the socket, it's possible it's too restrictive currently or perhaps still too permissive.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

Merge request reports