Skip to content

test: fix common.PIPE path bug

Rodrigo Muino Tomonari requested to merge github/fork/Trott/fix-pipe-yo into master

common.PIPE is returning a path name in test rather than in the tmp directory for each test. This is causing multiple test failures in CI. Make the path name inside the temporary directories again. This way the pipe is removed by common.refreshTmpDir() on POSIX.

The bug in common.PIPE was introduced in c34ae480.

Fixes: https://github.com/nodejs/node/issues/16290 Fixes: https://github.com/nodejs/node/issues/16323

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports