Skip to content

http2: fix compiler errors in debug statements

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/patch-http2-fix-debug into master

When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. I'm not certain if this is something about my system or if I'm missing something here since no one else has noticed... then again maybe I'm the only one using --debug-http2 at this moment.

../src/node_http2.cc:141:17: error: cannot pass object of non-trivial type 'node::AliasedBuffer<unsigned int,
      v8::Uint32Array>::Reference' through variadic function; call will abort at runtime [-Wnon-pod-varargs]
                buffer[IDX_SETTINGS_HEADER_TABLE_SIZE]);

This fixes the issue by casting to uint32_t.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

Merge request reports