Skip to content

build: fix npm install with --shared

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/fix16437 into master

The npm install rules had a hidden dependency on the node binary install rule creating the $PREFIX/bin directory.

Because with ./configure --shared no binary is created, the rule subsequently failed. Fix that by creating the directory before creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a node binary is a separate question. This commit is not taking positions. :-))

Regression introduced in commit ed8c89a0 ("build: fix shared installing target") which, as the commit log indicates, was itself a bug fix for the ./configure --shared install.

Fixes: https://github.com/nodejs/node/issues/16437 Refs: https://github.com/nodejs/node/pull/15148

Merge request reports