Skip to content

net: fix timeout with null handle

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/patch-fix-net-timeout-throw into master

Seems like there's a scenario where _onTimeout somehow gets called with _handle set to null. If anyone has any ideas on how this is possible then let me know so I can put together a better test than I have so far.

This might need to be expedited (< 48 hrs) and turned into 8.8.1? Not sure... 😔 😓 At least it's not LTS yet... *sigh*

Fixes: https://github.com/nodejs/node/issues/16484 Refs: https://github.com/nodejs/node/pull/15791

/cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

net, test

Merge request reports