Skip to content

src: do not include x.h if x-inl.h is included

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/remove-dup-header into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Refs: https://github.com/nodejs/node/issues/16519

Looks like V8 does not do this anymore: https://github.com/nodejs/node/blob/master/deps/v8/src/objects.cc#L12

So remove the headers. FWIW, less includes to sort, also makes the churn smaller if we want to use clang-format.

Also add this rule to the C++ style guide.

This could use a pre-backport, I can open those if this gets landed (this patch is created with a script anyway).

cc @bnoordhuis

Merge request reports