Skip to content

src: explicitly register built-in modules

Rodrigo Muino Tomonari requested to merge github/fork/yhwang/remove-attr-constructor into master

Previously, built-in modules are registered before main() via __attribute__((constructor)) mechanism in GCC and similiar mechanism in MSVC. This causes some issues when node is built as static library. Calling module registration function for built-in modules in node::Init() helps to avoid the issues.

Refs: https://github.com/nodejs/node/pull/14986#issuecomment-332758206 Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports