Skip to content

inspector: include node_platform.h header

Rodrigo Muino Tomonari requested to merge github/fork/alexeykuzmin/include-node-platform-dot-h into master

When Node.js is compiled as a part of the Electron build clang generates a couple of errors (see below). Including a header instead of using a forward declaration fixes them. It would be great if the code could be changed in the Node.js repo so Electron wouldn't have to have a patch for that.

../../vendor/node/src/inspector_agent.cc:516:16: error: member access into incomplete type 'node::NodePlatform'
      platform_->FlushForegroundTasksInternal();
               ^
../../vendor/node/src/inspector_agent.h:19:7: note: forward declaration of 'node::NodePlatform'
class NodePlatform;
      ^
../../vendor/node/src/inspector_agent.cc:670:15: error: assigning to 'v8::Platform *' from incompatible type 'node::NodePlatform *'
  platform_ = platform;
              ^~~~~~~~
2 errors generated.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector

Merge request reports