Skip to content

test: fix flaky test-http2-server-rst-stream.js

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-test-http2-server-rst-stream into master

I believe this test has some problems with concurrency but not 100% certain yet. Previous version was failing when I ran a heavy duty stress test on my machine but it's also possible there's something wrong in the http2 code. (Will run stress test CIs to try & confirm.)

Please don't approve until stress tests are done. I'm not even sure myself if this is correct. 😆

Fixes: https://github.com/nodejs/node/issues/16688

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports