Skip to content

crypto: Better docs for cases where peer's public key is invalid

Rodrigo Muino Tomonari requested to merge github/fork/j0t3x/cryptoinvalidpubkey into master

changes in c++ are in the computeSecret function, but the thrown exception that was moved to JS land was in BufferToPoint function, here i let the allocation error be thrown so the only value returned is the nullptr that i use later to catch the error in computeSecret, to then construct the exception in JS land.

an ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error was added to errors.js and with that, subsequent changes to docs and tests were made.

Fixes: https://github.com/nodejs/node/issues/16625 Refs: https://www.iacr.org/archive/pkc2003/25670211/25670211.pdf

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto, doc, test

Merge request reports