Skip to content

deps: cherry-pick b8331cc030 from upstream V8

Original commit message:

I believe the paths to the V8 include headers are incorrect. The
paths to other sources seem to be relative to the parent directory.

When building Node.js I get the following warning on Windows:
Warning: Missing input files:
deps\v8\src\..\..\include\v8-inspector-protocol.h
deps\v8\src\..\..\include\v8-inspector.h

This commit updates the two include paths.

Bug:
Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f
Reviewed-on: https://chromium-review.googlesource.com/743981
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49121}

This commit also increments the v8_embedder_string version.

Fixes: https://github.com/nodejs/node/issues/16614 Refs: https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

cc @nodejs/v8

Merge request reports

Loading