Skip to content

src: use unique_ptr for scheduled delayed tasks

Rodrigo Muino Tomonari requested to merge github/fork/fhinkel/nov/refactor_delete_from_scheduled_tasks into master

Use std::unique_ptr for delayed tasks in the scheduled delayed tasks vector. This makes it clear that the vector has ownership of the delayed tasks and is responsible for deleting them.

Use a custom deleter for the pointers because libuv needs to close the handle and then delete the data. Provide the handle when creating the pointer instead of invoking the special delete action everytime an element is removed from the vector.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports