Skip to content

Rename internalModuleReadFile to internalModuleReadJSON.

Rodrigo Muino Tomonari requested to merge github/fork/jdalton/internal-module-read-file into master

This PR addresses #17076 (closed) by simply renaming internalModuleReadFile to internalModuleReadJSON.

With the addition of PR #15767 the internal InternalModuleReadFile and pseudo exposed process.binding("fs").internalModuleReadFile are no longer generic read file helpers and are essentially locked down to just json. InternalModuleReadFile was more generically useful before and could have been applied to loading more than just json.

I think the name InternalModuleReadFile, and the pseudo exposed process.binding("fs").internalModuleReadFile, should either be renamed or a new internal for json-only should be created (maybe that wraps InternalModuleReadFile).

I'm actually cool with keeping internalModuleReadFile just for the potential to use it for other things besides json, but this was the easy way to address the root of #17076 (closed) without digging into c++.

Merge request reports