build: do not build doc in source tarball
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
tests and/or benchmarks are included -
documentation is changed or added -
commit message follows commit guidelines
Affected core subsystem(s)
build
Fixes: https://github.com/nodejs/node/issues/16650
This is the real fix for https://github.com/nodejs/node/issues/16650 , which makes sure that GNU make v4.x won't build the docs if the source is extracted from the source tarball (i.e. doc/api contains built docs) (see the theory in https://github.com/nodejs/node/issues/16650#issuecomment-345265520)
Also during the investigation of this issue I think I have a better idea about https://github.com/nodejs/node/issues/17043, I'll open a separate PR with a more robust available-node
and try to fix all the $(NODE)
usage there, hopefully fixing the makefile regression. For this PR the current implementation is enough.
cc @nodejs/build