Skip to content

build,win,msi: support WiX with VS2017

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-HBH-vs2017-wix into master

To support releasing with VS2017, we need to be able to build the MSI with it. This PR:

  • Passes the Windows SDK version to the MSBuild invocation that builds the MSI, to support SDKs other than 8.1.
  • Adds warnings if WiX cannot be used. WiX for VS2017 requires an extension to be installed because of MSBuild changes, this adds a warning if it's missing.
  • Adds a note in the documentation about WiX.

Ref: https://github.com/nodejs/node/issues/13052 Ref: https://github.com/nodejs/node/pull/16969

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

build, win, msi

Merge request reports