Skip to content

build: refactor addon targets

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/refactor-addon into master
  • Extracts the common bits out as ADDON_PREREQS, build-single-addon, build-multiple-addon
  • Changes test-ci to depend on the build stamps instead of the build targets, since those rely on $(NODE_EXE) and would trigger a build/linking every time they get run.
  • Checks that ./node -> out/Release/node is not a broken link, that is, out/Release/node is not deleted

This would probably help investigating https://github.com/nodejs/node/issues/17043 where the link seems to get broken in the middle of a addon build.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports