Skip to content

inspector: no async tracking for promises

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/inspector-async-no-promise-tracking into master

Promise instances are already tracked by V8 itself. This fixes sequential/test-inspector-async-stack-traces-promise-then in debug mode (it previously crashed because our tracking and the V8 tracking were not properly nested).

Ref: https://chromium-review.googlesource.com/c/v8/v8/+/707058 (fyi @ak239) Fixes: https://github.com/nodejs/node/issues/17017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector

Merge request reports