Skip to content

[v8.x backport] build: fix cctest compilation

Rodrigo Muino Tomonari requested to merge github/fork/danbev/backport-16887-to-v8.x into v8.x-staging

Currently the cctest target compiles sources files even though they are compiled for the node target. This is my fault as when I worked on the task of getting the cctest to use the object files from the node target I missed a few sources that were being included from node.gypi. This also effects the build time as these sources are compiled twice.

This commit moves the conditions in question into the node target in node.gyp. With this commit there should be no object files in out/Release/obj.target/cctest/src/ (the path will vary depending on the operating system being used).

Refs: https://github.com/nodejs/node/pull/16887 PR-URL:https://github.com/nodejs/node/pull/16887 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports