Skip to content

[v6.x backport] build: remove cctest extension

Rodrigo Muino Tomonari requested to merge github/fork/yhwang/backport-16680-to-v6.x into v6.x-staging

cctest has so.59 extension when building node shared library in linux. The appending is defined in node.gypi and the cctest target in node.gyp includes node.gypi. Moving the appending from node.gypi to node target in node.gyp fixes the issue.

Signed-off-by: Yihong Wang yh.wang@ibm.com

Original PR-URL: https://github.com/nodejs/node/pull/16680 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Gibson Fahnestock gibfahn@gmail.com Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com Reviewed-By: Refael Ackermann refack@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports