Add more robust option parsing [WIP] (!1726) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/evanlucas/optionparser into master May 18, 2015

This is a start for adding more robust option parsing. I wanted to go ahead and open this to get some feedback on the direction.

Note: this is by no means complete and there are failing tests from it currently

I have included the option parser found at https://github.com/JGiard/tclap. I had to make some modifications to allow passing through v8 options.

TODO

Migrate debug option parsing
Make sure the --icu-data-dir flag works as intended

Questions

Is this a direction that we are interested in going?
This library throws exceptions in the event a flag that requires an argument fails to validate. So, it requires removing the -fno-exceptions flag. Is that acceptable?

In general, I would appreciate any/all feedback to see if this is something that should be pursued.