Skip to content

src: remove `ClearFatalExceptionHandlers()`

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/no-clear-fatal-exception-handlers into master

At its call sites, ClearFatalExceptionHandlers() was used to make the process crash as soon as possible once an exception occurred, without giving JS land a chance to interfere.

ClearFatalExceptionHandlers() awkwardly removed the current domain and any uncaughtException handlers, whereas a clearer way is to execute the relevant reporting (and exit()) code directly.

Refs: https://github.com/nodejs/node/pull/17159 Refs: https://github.com/nodejs/node/pull/17324

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports