Skip to content

deps: V8: backport 14ac02c from upstream

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/v8-6623 into v9.x

This fixes a memory leak in the CPU profiler: https://bugs.chromium.org/p/v8/issues/detail?id=6623

This affects master, 9.x and 8.x. master should pick this up through a regular V8 update (if the merge gets approved). This PR is for 9.x. This should cherry-pick to 8.x easily except for the version bump, which will need to be migrated to v8-version.h.

Original commit message:

[cpu-profiler] Clear code entries when no observers are present.

Performed manual testing as well by making 20 CPU profile recordings of loading http://meduza.io page. Without the patch the page renderer memory size grows beyond 300MB. With the patch it remains below 200MB.

BUG=v8:6623

Change-Id: Ifce541b84bb2aaaa5175520f8dd49dbc0cb5dd20 Reviewed-on: https://chromium-review.googlesource.com/798020 Commit-Queue: Alexei Filippov alph@chromium.org Reviewed-by: Yang Guo yangguo@chromium.org Cr-Commit-Position: refs/heads/master@{#49914}

Ref: https://github.com/v8/v8/commit/14ac02c49c7a364059704537a10abae4feb15a88

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps:V8

R = @nodejs/v8 CI: https://ci.nodejs.org/job/node-test-pull-request/11929/ V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1102/

Merge request reports