Skip to content

http: simplify `isInvalidPath`

Rodrigo Muino Tomonari requested to merge github/fork/starkwang/http-client-simplify into master

The loop unrolling here shows no performance benefits in V8 6.3 any longer, so we can get rid of it. This PR is to simplify isInvalidPath without obvious performance regression.

                                               improvement confidence    p.value
 http/create-clientrequest.js n=1000000 len=1       -3.06 %          * 0.03418092
 http/create-clientrequest.js n=1000000 len=128      0.20 %            0.88729859
 http/create-clientrequest.js n=1000000 len=16      -0.50 %            0.66812482
 http/create-clientrequest.js n=1000000 len=32       2.21 %            0.06679157
 http/create-clientrequest.js n=1000000 len=64      -0.06 %            0.95083016
 http/create-clientrequest.js n=1000000 len=8       -0.61 %            0.49496794
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http

Merge request reports