Skip to content

[6.x] cherry-pick sampling heap profiler fixes from upstream

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/v8-4959 into v6.x-staging

The V8 sampling heap profiler has some bugfixes that are available upstream that are not available in Node 6 (V8 5.1). These fix sporadic crashes as seen on https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs/issues/90. The fixes are already present in Node 8.

These are two out of the three CLs in https://bugs.chromium.org/p/v8/issues/detail?id=4959. The third CL is an API change that makes it possible to optionally force a GC at the time the profile is gathered; however it is not essential for fixing the crashes. Even though the API change is likely ABI compatible, I omitted it because it is not essential.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps:v8

/cc @nodejs/v8 CI: https://ci.nodejs.org/job/node-test-pull-request/12071/ V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1111/

Merge request reports