Skip to content

test: remove ambiguous error messages from test_error

Rodrigo Muino Tomonari requested to merge github/fork/nadrane/improve-tests into master

I got this project through @trott on http://nodetodo.org/. Thank you for reviewing it.

Here's a description of the changes:

assert.strictEqual accepts 3 arguments, the last of which allows for user-specified error message to be thrown when the assertion fails. Unfortunately, this error message is less helpful than the default when it is vague. This commit removes vague, user-specified error messages, instead relying on clearer, default error messages.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Merge request reports