Skip to content

[v9.x] test: refactor test-repl

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/backport-v9.x-17926 into v9.x-staging
  • Switch over to async tracking through promises/async fns
  • Remove an unused temp dir refresh
  • Inline the multiline/npm text prompts into expectations
  • Unify handling prompts/stripping prompts out
  • Make sure no unexpected data is received by requireing all lines to be matched, rather than chunks received from the REPL. This made the test too loose in terms of matched lines and too strict in terms of stream chunking requirements.
  • Some general cleanup

PR-URL: https://github.com/nodejs/node/pull/17926

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports