Skip to content

[v9.x backport] test: move common.fires() to inspector-helper

Rodrigo Muino Tomonari requested to merge github/fork/Trott/backport-17401 into v9.x-staging

common.fires() is specific to the inspector tests so move it to inspector-helper.js. The one REPL test that used common.fires() does not seem to need it. It provided a 1 second timeout for operations, but that timeout appears both arbitrary and ineffective as the test passes if it is reduced to even 1 millisecond.

PR-URL: https://github.com/nodejs/node/pull/17401 Reviewed-By: Jon Moss me@jonathanmoss.me Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports