Skip to content

child_process: do not ignore proto values of env

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-env-prototype-key-values into master

This reverts part of the behaviour introduced in a recent PR, and updates the test. Without this change, CitGM and other packages are broken. I would like to have this fast-tracked (like, land within an hour or less) because as things are, CitGM is completely broken.

Also, I would like to propose, that going forward all changes that are labeled as semver-minor/major/patch MUST have a CitGM run to land. If any issues are found, collaborators & TSC should decide whether those are blocking or not. In either case, an effort should be made to fix the impacted modules before the PR lands — or at the very least in cases where those modules are integral to the Node.js core project.

Refs: https://github.com/nodejs/node/commit/85739b6c5b5d12204a81de18ceddf2d357effb8b Fixes: https://github.com/nodejs/citgm/issues/536

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process, test

Merge request reports