Skip to content

stream: delete unused code

Rodrigo Muino Tomonari requested to merge github/fork/MoonBall/delete-unused-code-of-transform-stream into master

In implementation of stream.Writable, writable._write() is always called with a callback that is _writableState.onwrite(). And In afterTransform(), ts.writechunk and ts.writecb are assigned to null. So, ts.writecb is a true value if ts.writechunk isn't null.

From the view of stream.Writable, only ts.writecb can inform it about the end of writing chunk to the underlying. So a callback is essential to call writable._write(). So, ts.writecb is a true value if ts.writechunk isn't null.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

Merge request reports