Skip to content

[v8.x backport] http, tls: better support for IPv6 addresses

Rodrigo Muino Tomonari requested to merge github/fork/mattiasholmlund/backport-14772-to-v8.x into v8.x-staging

Backport of https://github.com/nodejs/node/pull/14772 to v8.x. The cherry-pick succeeded without any manual modifications. The original PR was included in Version 9.1.0 2017-11-07, so it has been out in the wild for over two months now.

make -j4 test passes (on OS X) for this PR.

  • Properly handle IPv6 in Host header when setting servername.
  • When comparing IP addresses against addresses in the subjectAltName field of a certificate, format the address correctly before doing the string comparison.

PR-URL: https://github.com/nodejs/node/pull/14772 Fixes: https://github.com/nodejs/node/issues/14736 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: James M Snell jasnell@gmail.com

Merge request reports