Skip to content

[v9.x] deps: cherry-pick 55b4879 from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/heapdump-check into v9.x-staging

Original commit message:

[heap-profiler] remove bogus DCHECK

A map’s `constructor_or_backpointer` can be any kind of value,
because `fn.prototype = foo` sets that field to `foo` if the
latter is not a `JSReceiver`; so the `DCHECK` that is being
removed here was invalid.

Refs: https://github.com/nodejs/node/issues/18223
Bug: node:18223
Change-Id: Ia6449c07bb724e515d73b162369ab36ab1d89c6b
Reviewed-on: https://chromium-review.googlesource.com/874472
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50735}

Refs: https://github.com/v8/v8/commit/55b48798eb3f443b9d04f7d43c55b3dada4f9de7 Fixes: https://github.com/nodejs/node/issues/18223

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports